Skip to content

DEPR update dedeprecation message for np.ptp #28665 #6581 #30401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

DEPR update dedeprecation message for np.ptp #28665 #6581 #30401

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
da3c79a
update dedeprecation message for np.ptp DEPR #28665 #6581
hasnain2808 Dec 22, 2019
d89d7f6
update dedeprecation message for np.ptp DEPR #28665 #6581 requested c…
hasnain2808 Dec 23, 2019
d9e955e
remove code for ptp()
hasnain2808 Dec 23, 2019
08a5f3e
remove comments)
hasnain2808 Dec 23, 2019
3df0283
remove comments
hasnain2808 Dec 23, 2019
add3e23
solve errors
hasnain2808 Dec 24, 2019
b28bc3a
test at which command azure pipelines failing
hasnain2808 Dec 24, 2019
86c11c9
use numpy.array_equal instead of ==
hasnain2808 Dec 24, 2019
5d8d35f
use numpy.array_equal instead of ==
hasnain2808 Dec 24, 2019
c9ee01a
Revert "use numpy.array_equal instead of =="
hasnain2808 Dec 24, 2019
0610de5
Revert "use numpy.array_equal instead of =="
hasnain2808 Dec 24, 2019
f1e82ab
Revert "test at which command azure pipelines failing"
hasnain2808 Dec 24, 2019
d8b649e
Revert "solve errors"
hasnain2808 Dec 24, 2019
eeba706
Revert "remove comments"
hasnain2808 Dec 24, 2019
0c19cd3
Revert "remove comments)"
hasnain2808 Dec 24, 2019
ab8343a
Revert "remove code for ptp()"
hasnain2808 Dec 24, 2019
69d1c0a
Revert "update dedeprecation message for np.ptp DEPR #28665 #6581 req…
hasnain2808 Dec 24, 2019
8c0bb01
removed ptp code and tests and also put a print statement to understa…
hasnain2808 Dec 24, 2019
cc66afe
removed ptp code and tests and also put print statements to print typ…
hasnain2808 Dec 25, 2019
d9e9ac7
casting pandas to numpy before calling np.ptp()
hasnain2808 Dec 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10198,7 +10198,10 @@ def nanptp(values, axis=0, skipna=True):
nmin = nanops.nanmin(values, axis, skipna)
warnings.warn(
"Method .ptp is deprecated and will be removed "
"in a future version. Use numpy.ptp instead.",
"in a future version. Use numpy.ptp instead."
"if you are already using numpy.ptp and still getting this message"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"if you are already using numpy.ptp and still getting this message"
"if you are already using numpy.ptp and still getting this message, "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"please call to_numpy() to avoid this message in future calls"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"please call to_numpy() to avoid this message in future calls"
"please call to_numpy() to avoid this message in future calls. "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"eg : np.ptp(pd.Series([1, 2, 3]).to_numpy())",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"eg : np.ptp(pd.Series([1, 2, 3]).to_numpy())",
"For example: np.ptp(pd.Series([1, 2, 3]).to_numpy())",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

FutureWarning,
stacklevel=4,
)
Expand Down