Clean Up nogil Warning From Parsers #30369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
presumably the nogil version was for performance. does that turn out not to matter? |
| @@ -171,12 +171,9 @@ cdef extern from "parser/tokenizer.h": | |||
| int64_t skip_first_N_rows | |||
| int64_t skipfooter | |||
| # pick one, depending on whether the converter requires GIL | |||
|
Nogil is still in play here; the one function that requires it just explicitly grabs it now |
jreback
requested changes
Dec 20, 2019
|
Ran the csv benchmarks and they showed no change. |
jreback
reviewed
Jan 1, 2020
|
@jreback all green |
jreback
approved these changes
Jan 2, 2020
|
thanks @WillAyd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think just easier to ensure The GIL is acquired within the C function rather than all of the current casting / indirection.
Eliminates the following warning: