ENH: meth 'DataFrame.to_pickle' and func 'read_pickle' to accept URL GH#30163

[suzutomato]

• closes pandas.read_pickle can take buffer object as well, not only str #30163
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[jreback]

@suzutomato i see multiple PRs that you are opening and then closing
don’t open new ones if u make a change, rather push to the same one

this needs tests

[jreback]

needs tests

[bashtage]

It feels like getting pickles over networks is antithetical to their recommended use due to the security implications.

[suzutomato]

Sorry for the mess I've made, as well as the delay on this PR.
Tests were added.

2 Azure pipelines were failed/canceled due to timeout. I'll push agin later if that's the best way to rerun them.
Thank you,

[jreback]

can you merge master and ping on green.

[suzutomato]

@jreback
Thank you for the comment, updated and merged.
Now all is green. ptal.

[jreback]

looks good a few comments, ping on green.

[pep8speaks]

Hello @suzutomato! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-09 12:17:29 UTC

[suzutomato]

@jreback Thank you for review. Updated accordingly, please take a look. Let me know if I misunderstood anything.

[TomAugspurger]

It feels like getting pickles over networks is antithetical to their recommended use due to the security implications.

That was my initial reaction too. Do we want to encourage this?

[jreback]

It feels like getting pickles over networks is antithetical to their recommended use due to the security implications.

That was my initial reaction too. Do we want to encourage this?

this is a pretty common pattern actually;
security is out of scope as this is up to the user

[TomAugspurger]

Fair enough. We do have a warning in the read_pickle docs. May want to re-emphasize that in the filepath_or_buffer section.

[TomAugspurger]

Looks good, aside from a doc question.

[jreback]

lgtm. @TomAugspurger ok here?

[TomAugspurger]

Fixed the merge conflict. Good to merge when CI passes.

[jreback]

thanks @suzutomato very nice!

[suzutomato]

Thank you @jreback and @TomAugspurger for guidance and your patience!
It was fun!