CLN: .format to f-string formatting in various files #30294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Dec 17, 2019
|
@kpmccahill : Thanks for opening this PR! And welcome to pandas! 🚀 The changes look pretty good overall. I have one question about them that's directed towards fellow maintainers as you can see above. |
Thanks! And I'm gonna be honest I wasn't too sure about that one myself for the same reason you mentioned. But I thought I'd give it a go anyways just to see. |
gfyoung
reviewed
Dec 17, 2019
pandas/_config/config.py
Outdated
| @@ -388,7 +388,7 @@ class option_context: | |||
| Examples | |||
| -------- | |||
|
|
|||
| >>> with option_context('display.max_rows', 10, 'display.max_columns', 5): | |||
| with option_context('display.max_rows', 10, 'display.max_columns', 5): | |||
There was a problem hiding this comment.
I thought those were some characters I had accidentally added, but now that I look at the master I realize they're supposed to be there, oops
datapythonista
approved these changes
Dec 17, 2019
WillAyd
approved these changes
Dec 17, 2019
|
Thanks @kpmccahill ! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff