CLN: changed .format to f-string in pandas/core/indexes #30273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # return self._shallow_copy(closed=closed) |
There was a problem hiding this comment.
is there a reason to remove this comment?
There was a problem hiding this comment.
No. I put it back as it was placed.
pandas/core/indexes/period.py
Outdated
| list(set(fields) - valid_field_set)[0] | ||
| ) | ||
| "__new__() got an unexpected keyword argument " | ||
| f"{list(set(fields) - valid_field_set)[0]}" |
There was a problem hiding this comment.
could do this outside f-space.
There was a problem hiding this comment.
separated that line with the new variable.
topper-123
approved these changes
Dec 15, 2019
|
Thanks, @makeajourney . Welcome to take more of these. |
99 tasks
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #29547
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff