-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Made date time sources usage more explicit in setup.py #30266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmm i am always leary of changing things like this, last time we did things didn't recompile properly locally. meaning if you then just change something that was formerly a source (but now only a depends) it didn't recompile unless you clean. @jbrockmendel can you test out. |
Cool thanks both for the feedback. Just to clarify on this one I'm just removing sources that aren't used by the module at all, not necessarily converting from The problem I'm trying to address is that with parallel builds everything in sources gets recompiled when specified as such, and I think race conditions could make things fail This doesn't fully solve the recompilation problem but just removes the compilation step from modules that don't reference those C extensions at all, whether directly or through import of another module |
Any objection to rolling with this for now and reverting if issues pop up? Have it as a mini goal to get parallelized builds which I think this is a pre-cursor of |
+1 |
Cool I'll merge for now and obviously can revert if anything pops up cc @pandas-dev/pandas-core for visibility |
Not sure this fully solves #30236 but doesn't hurt and makes things more explicit