Skip to content

Made date time sources usage more explicit in setup.py #30266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Dec 13, 2019

Not sure this fully solves #30236 but doesn't hurt and makes things more explicit

@pep8speaks
Copy link

pep8speaks commented Dec 13, 2019

Hello @WillAyd! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-13 22:11:36 UTC

@WillAyd WillAyd added the CI Continuous Integration label Dec 13, 2019
@jreback
Copy link
Contributor

jreback commented Dec 15, 2019

hmm i am always leary of changing things like this, last time we did things didn't recompile properly locally. meaning if you then just change something that was formerly a source (but now only a depends) it didn't recompile unless you clean.

@jbrockmendel can you test out.

@jbrockmendel
Copy link
Member

I agree with both @WillAyd that this looks correct and is more explicit and @jreback that in the past this has been a fragile minefield. On the margin I'm inclined to trust Will on this as it is easy to revert if problems pop up.

@WillAyd
Copy link
Member Author

WillAyd commented Dec 16, 2019

Cool thanks both for the feedback. Just to clarify on this one I'm just removing sources that aren't used by the module at all, not necessarily converting from sources -> depends

The problem I'm trying to address is that with parallel builds everything in sources gets recompiled when specified as such, and I think race conditions could make things fail

This doesn't fully solve the recompilation problem but just removes the compilation step from modules that don't reference those C extensions at all, whether directly or through import of another module

@WillAyd
Copy link
Member Author

WillAyd commented Dec 18, 2019

Any objection to rolling with this for now and reverting if issues pop up? Have it as a mini goal to get parallelized builds which I think this is a pre-cursor of

@jbrockmendel
Copy link
Member

+1

@WillAyd
Copy link
Member Author

WillAyd commented Dec 18, 2019

Cool I'll merge for now and obviously can revert if anything pops up

cc @pandas-dev/pandas-core for visibility

@WillAyd WillAyd added this to the 1.0 milestone Dec 18, 2019
@WillAyd WillAyd merged commit b6168e9 into pandas-dev:master Dec 18, 2019
@WillAyd WillAyd deleted the clean-sources branch December 18, 2019 18:34
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants