CLN: more lgtm.com cleanups #30259
Merged
CLN: more lgtm.com cleanups #30259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -179,7 +179,6 @@ def _generate_range_overflow_safe_signed( | |||
| # watch out for very special case in which we just slightly | |||
| # exceed implementation bounds, but when passing the result to | |||
| # np.arange will get a result slightly within the bounds | |||
| assert endpoint >= 0 | |||
There was a problem hiding this comment.
i see how this is redundant given L176 and L178, but it doesn't seem harmful
| @@ -168,7 +168,7 @@ def dispatch_fill_zeros(op, left, right, result): | |||
| # Note: no need to do this for truediv; in py3 numpy behaves the way | |||
| # we want. | |||
| result = mask_zero_div_zero(left, right, result) | |||
| elif op is op is rfloordiv: | |||
There was a problem hiding this comment.
this is definitiely wrong as is, but is it currently parsed as elif op is (op is rfloordiv): in which case it would also evaluate to False? If so, there may be a bug hidden in here
There was a problem hiding this comment.
can't seem to find a bug here. This code must work!
>>> def rfloordiv(left, right):
... return right // left
...
>>> op = rfloordiv
>>>
>>> op is op is rfloordiv
True
>>>
>>> op is (op is rfloordiv)
False
>>>
>>> (op is op) is rfloordiv
False
>>>
>>> op is rfloordiv
True
>>>
>>> 1 is 1 is 1
True
>>>
>>> (1 is 1) is 1
False
>>>
>>> 1 is (1 is 1)
False
>>>
jreback
reviewed
Dec 15, 2019
| @@ -398,24 +397,7 @@ def _agg(arg, func): | |||
| keys = list(arg.keys()) | |||
| result = OrderedDict() | |||
|
|
|||
| # nested renamer | |||
There was a problem hiding this comment.
hmm i guess this was previously used, ok.
|
thanks @simonjayhawkins |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.