CLN: various lgtm.com cleanups #30258
Conversation
| @@ -78,7 +78,8 @@ def itemsize(self): | |||
|
|
|||
| @classmethod | |||
| def construct_array_type(cls): | |||
| """Return the array type associated with this dtype | |||
| """ | |||
There was a problem hiding this comment.
Is this docstring not inherited from the base class?
There was a problem hiding this comment.
not as far as I'm aware. Should it be?
There was a problem hiding this comment.
It looks like inspect.getdoc(object) https://docs.python.org/3/library/inspect.html?highlight=inspect#inspect.getdoc could get the baseclass docstring.
I'm using VSCode and not showing baseclass docstring when no docstring exists on derived class.
_IntegerDtype().construct_array_type.__doc__ returns None if no docstring exists on derived class but help(_IntegerDtype().construct_array_type) does show the inherited doctstring.
There was a problem hiding this comment.
ok this is odd then I agree with @TomAugspurger that these should inherit the baseclass, odd that they are not.
|
thanks for the cleanups @simonjayhawkins |
No description provided.