Skip to content

DEPR: change DataFrame.append default sort kwarg #30251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2019
Merged

DEPR: change DataFrame.append default sort kwarg #30251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
899a931
DEPR: change DataFrame.append default sort kwarg
jbrockmendel Dec 13, 2019
a40d8b6
Update pandas/core/frame.py
jbrockmendel Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6664,7 +6664,7 @@ def infer(x):
# ----------------------------------------------------------------------
# Merging / joining methods

def append(self, other, ignore_index=False, verify_integrity=False, sort=None):
def append(self, other, ignore_index=False, verify_integrity=False, sort=False):
"""
Append rows of `other` to the end of caller, returning a new object.

Expand All @@ -6678,14 +6678,13 @@ def append(self, other, ignore_index=False, verify_integrity=False, sort=None):
If True, do not use the index labels.
verify_integrity : bool, default False
If True, raise ValueError on creating index with duplicates.
sort : bool, default None
sort : bool, default False
Sort columns if the columns of `self` and `other` are not aligned.
The default sorting is deprecated and will change to not-sorting
in a future version of pandas. Explicitly pass ``sort=True`` to
silence the warning and sort. Explicitly pass ``sort=False`` to
silence the warning and not sort.

.. versionadded:: 0.23.0
.. versionchanged:: 1.0.0

Changed to not sort by default.

Returns
-------
Expand Down