-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: min/max on empty categorical fails #30227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TomAugspurger
merged 16 commits into
pandas-dev:master
from
OliverHofkens:fix/minmax-on-empty-categorical
Dec 17, 2019
Merged
BUG: min/max on empty categorical fails #30227
TomAugspurger
merged 16 commits into
pandas-dev:master
from
OliverHofkens:fix/minmax-on-empty-categorical
Dec 17, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a .. versionchanged
to indicate that an NA value is returned for empty arrays.
topper-123
reviewed
Dec 12, 2019
jreback
requested changes
Dec 12, 2019
jreback
reviewed
Dec 12, 2019
jreback
requested changes
Dec 12, 2019
jreback
reviewed
Dec 12, 2019
TomAugspurger
approved these changes
Dec 17, 2019
Thanks! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Currently on master, the following fails:
ValueError: zero-size array to reduction operation maximum which has no identity
Other dtypes return
NaN
when callingmin()
ormax()
on an empty Series. This PR changes the behavior of Categoricals to be the same.Note that current behavior causes a downstream bug in Dask here: dask/dask#5645, so this PR could fix that bug as well.