REF: dont alter state in pytables read_axes #30184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-pytables-read_axes
…f-pytables-read_axes
…f-pytables-read_axes
…f-pytables-read_axes
jreback
requested changes
Dec 11, 2019
|
|
||
| Returns | ||
| ------- | ||
| index : listlike to become an Index |
There was a problem hiding this comment.
ideally type at some point (e.g. return value)
There was a problem hiding this comment.
yah, ATM we're not consistent about what this is (e.g. sometimes list) so id like to to get this more specific
pandas/io/pytables.py
Outdated
| index = self.index_axes[0].values | ||
|
|
||
| axes = list(self.axes) | ||
| inds = [i for i in range(len(axes)) if axes[i] is self.index_axes[0]] |
| frames = [] | ||
| for a in self.values_axes: | ||
| for i, a in enumerate(self.axes): |
There was a problem hiding this comment.
confusing y ou are using self.axes here again
There was a problem hiding this comment.
we need i to do the lookup result[i] and a to do the check just below. there may be a nicer way to do this if/when values_axes ceases to be stateful
…f-pytables-read_axes
|
rebased+green |
…f-pytables-read_axes
|
Not sure whats going on here |
jreback
approved these changes
Dec 12, 2019
|
thanks |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.