DEPR: to_timedelta box kwarg #30177
Merged
DEPR: to_timedelta box kwarg #30177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good!
There is still a test using it apparently:
______________________ TestTimedeltas.test_to_timedelta _______________________
[gw0] win32 -- Python 3.7.5 C:\Miniconda\envs\pandas-dev\python.exe
self = <pandas.tests.indexes.timedeltas.test_tools.TestTimedeltas object at 0x000002A4A29A7AC8>
def test_to_timedelta(self):
def conv(v):
return v.astype("m8[ns]")
d1 = np.timedelta64(1, "D")
with tm.assert_produces_warning(FutureWarning):
> assert to_timedelta("1 days 06:05:01.00003", box=False) == conv(
d1
+ np.timedelta64(6 * 3600 + 5 * 60 + 1, "s")
+ np.timedelta64(30, "us")
)
E TypeError: to_timedelta() got an unexpected keyword argument 'box'
pandas\tests\indexes\timedeltas\test_tools.py:21: TypeError
doc/source/whatsnew/v1.0.0.rst
Outdated
| @@ -540,6 +540,7 @@ or ``matplotlib.Axes.plot``. See :ref:`plotting.formatters` for more. | |||
| - Changed the the default value of `inplace` in :meth:`DataFrame.set_index` and :meth:`Series.set_axis`. It now defaults to ``False`` (:issue:`27600`) | |||
| - Removed the previously deprecated :attr:`Series.cat.categorical`, :attr:`Series.cat.index`, :attr:`Series.cat.name` (:issue:`24751`) | |||
| - :func:`to_datetime` no longer accepts "box" argument, always returns :class:`DatetimeIndex` or :class:`Index`, :class:`Series`, or :class:`DataFrame` (:issue:`24486`) | |||
| - :func:`to_timedelta` no longer accepts "box" argument, always returns :class:`TimedeltaIndex` or :class:`Index`, :class:`Series`, or :class:`DataFrame` (:issue:`24486`) | |||
There was a problem hiding this comment.
Can you combine this into the above, by saying "to_datetime and to_timedetal no longer accept .." ?
jorisvandenbossche
approved these changes
Dec 11, 2019
|
Thanks! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably was intended to be done at the same time as the to_datetime version.
Also cleaning up some other things picked up by grepping for "deprecate"