STY: Underscores for long numbers #30169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Dec 9, 2019
pandas/core/frame.py
Outdated
| return "{num:3.1f}{size_q} {x}".format( | ||
| num=num, size_q=size_qualifier, x=x | ||
| ) | ||
| num /= 1024.0 | ||
| num /= 1_024.0 |
There was a problem hiding this comment.
i dont think this adds clarity. AFAIK we dont have a policy on this, but maybe something like 7+ digits?
There was a problem hiding this comment.
I agree, I also think for relatively small numbers this does not improve readability IMO.
Also, I don't think we need to do this for random numbers in the tests. Yes to using underscores in meaningful numbers (such as in ccalendar.DAY_SECONDS * 1_000_000_000), but for random values in tests asserts, I don't see the added value.
5 tasks
|
thanks @MomIsBestFriend yeah agree with the others, this is for reading clarify, so want to use it mainly on long static constants. |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff