REF: finish setting pytables IndexCol attrs in constructor #30161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Dec 9, 2019
| @@ -2490,8 +2475,7 @@ def get_atom_timedelta64(cls, shape): | |||
| class GenericDataIndexableCol(DataIndexableCol): | |||
There was a problem hiding this comment.
Can we just blow this class away altogether now?
jreback
requested changes
Dec 10, 2019
| md = self.read_metadata(c) | ||
| meta = "category" if md is not None else None | ||
| # TODO: figure out why these two versions of `meta` dont always match. |
There was a problem hiding this comment.
So ever place where we set self.meta it is equivalent to meta = "category" if md is not None else none, but in this one place where we read it from the file, there is one test case where it doesnt match, and i dont know why.
if/when that is resolved, meta can be made a property
|
can you rebase |
…f-pytables-get_attr
|
rebased+green |
jreback
approved these changes
Dec 12, 2019
|
k thanks |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're not all the way done, but this is a big milestone