Skip to content

DOC/STY: Cleaned pandas/_libs/{internals,interval}.pyx #30157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm though deferring to @jbrockmendel on discussion around Cython annotations

@WillAyd WillAyd added Code Style Code style, linting, code_checks Typing type annotations, mypy/pyright type checking labels Dec 9, 2019
@WillAyd WillAyd added this to the 1.0 milestone Dec 9, 2019
@ShaharNaveh ShaharNaveh changed the title STY/TYP: pandas/_libs/{internals,interval}.pyx DOC/STY: Cleaned pandas/_libs/{internals,interval}.pyx Dec 10, 2019
@jreback jreback merged commit 6daa4a0 into pandas-dev:master Dec 10, 2019
@jreback
Copy link
Contributor

jreback commented Dec 10, 2019

thanks @MomIsBestFriend

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh ShaharNaveh deleted the CLN-_libs-#2 branch December 20, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants