Skip to content

DOC: added docs #30133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2019
Merged

DOC: added docs #30133

merged 3 commits into from
Dec 9, 2019

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@@ -212,18 +212,18 @@ def _validate_key(self, key, axis: int):
Parameters
----------
key : scalar, slice or list-like
The key requested
key requested.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should start with a capital letter, so OK to put “The” back in

@ShaharNaveh ShaharNaveh requested a review from WillAyd December 8, 2019 10:17
@WillAyd WillAyd added this to the 1.0 milestone Dec 9, 2019
@WillAyd WillAyd merged commit b664a80 into pandas-dev:master Dec 9, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 9, 2019

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the DOC-core-indexing branch December 9, 2019 09:27
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants