Skip to content

DOC: Cleaned docstrings in core/indexers.py #30131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2019
Merged

DOC: Cleaned docstrings in core/indexers.py #30131

merged 2 commits into from
Dec 23, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Dec 7, 2019 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

WillAyd
WillAyd requested changes Dec 7, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - a few minor things I think should be reverted

@ShaharNaveh ShaharNaveh requested a review from WillAyd December 8, 2019 10:24
jorisvandenbossche
jorisvandenbossche reviewed Dec 9, 2019
View reviewed changes
@jorisvandenbossche jorisvandenbossche changed the title DOC: Cleaned docs DOC: Cleaned docstrings in core/indexers.py Dec 9, 2019
jorisvandenbossche
jorisvandenbossche requested changes Dec 9, 2019
View reviewed changes
WillAyd
WillAyd requested changes Dec 10, 2019
View reviewed changes
simonjayhawkins
simonjayhawkins requested changes Dec 11, 2019
View reviewed changes
@jbrockmendel
Copy link
Member

@MomIsBestFriend can you rebase

@ShaharNaveh
Copy link
Member Author

rebased @jbrockmendel

MomIsBestFriend and others added 2 commits December 22, 2019 23:49
@ShaharNaveh
Copy link
Member Author

Thank you @jorisvandenbossche

@jorisvandenbossche
Copy link
Member

(Will merge when green)

@jorisvandenbossche jorisvandenbossche merged commit 64617cb into pandas-dev:master Dec 23, 2019
@jorisvandenbossche
Copy link
Member

Thanks @MomIsBestFriend !

@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Dec 23, 2019
@ShaharNaveh ShaharNaveh deleted the DOC-core-indexers branch December 23, 2019 13:34
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
@ShaharNaveh @jorisvandenbossche @AlexKirko
DOC: Cleaned docstrings in core/indexers.py (pandas-dev#30131)
8866e4c 
Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd requested changes

@jorisvandenbossche jorisvandenbossche jorisvandenbossche requested changes

@simonjayhawkins simonjayhawkins simonjayhawkins requested changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ShaharNaveh @jbrockmendel @jorisvandenbossche @WillAyd @simonjayhawkins @alimcmaster1