Skip to content

DOC: Style format #30119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2019
Merged

DOC: Style format #30119

merged 2 commits into from
Dec 7, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Dec 6, 2019 •
edited
Loading

  • ref DOC: Style format #30054
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added the Docs label Dec 6, 2019
@jreback jreback added this to the 1.0 milestone Dec 6, 2019
@jreback
Copy link
Contributor

jreback commented Dec 6, 2019

cc @datapythonista

datapythonista
datapythonista reviewed Dec 7, 2019
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. Few comments but looks good, nice clean up.

Feel free to fix any docstring you want, but the ones of public objects are the ones we try to prioritize, since besides reading them on the code are rendered into the docs.

datapythonista
datapythonista approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fixes!

@WillAyd WillAyd merged commit 72cee4a into pandas-dev:master Dec 7, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 7, 2019

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the DOC-core-#2 branch December 8, 2019 09:04
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
DOC: Style format (pandas-dev#30119)
daa154a
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
DOC: Style format (pandas-dev#30119)
d8c8fee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ShaharNaveh @jreback @WillAyd @datapythonista