REF: implement io.pytables.DataCol._get_atom #30102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Refactor
jreback
requested changes
Dec 6, 2019
|
updated to use |
jreback
approved these changes
Dec 6, 2019
|
thanks |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion to #30101 with promised payoff (logically orthgonal, but will have merge conflict when the time comes)
This implements _get_atom and makes only one call to it on 3949. By making all the relevant methods into classmethods, we can call it before we've instantiated an instance. Then following #30100, we'll be able to pass
typto the constructor instead of pinning it. This in turn will let us passposinstead of callingset_pos.Also after both this and #30101, we can get to rip out a bunch of no-longer-needed state-altering methods.