-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
#29886 - Replace !r for repr() on pandas/io/parses.py #30073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
182c68b
#29886 - Replace rm -rf pandas/ for repr() on parses.py
JvPy 029ee4d
STY - Add repr to html.py and parsers.py - #29953
JvPy 4ea03fc
STY - Add repr to html.py and parsers.py - #29953
JvPy 9b9f283
Revert "#29886 - Replace rm -rf pandas/ for repr() on parses.py"
JvPy 80e8a1a
Revert "STY - Add repr to html.py and parsers.py - #29953"
JvPy 198c0a4
#29886 - Replace rm -rf pandas/ for repr() on parses.py
JvPy 848e542
STY - Add repr to html.py and parsers.py - #29953
JvPy eed4528
STY - fstrings on parser.py
JvPy 9305b3f
STY - removed unecessary repr
JvPy a42ba49
Readded repr(foo) to parsers.py
JvPy 2608e39
fix repr for parsers.py
JvPy 3702186
Merge branch 'master' into corrections
JvPy ae24a20
fix spaces on html.py
JvPy a5ce1f2
fix with black pandas on html.py
JvPy bbf9f81
removed fstrings
JvPy 2e63f0b
removed fstrings
JvPy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -913,8 +913,8 @@ def _get_options_with_defaults(self, engine): | |||||
pass | ||||||
else: | ||||||
raise ValueError( | ||||||
"The %r option is not supported with the" | ||||||
" %r engine" % (argname, engine) | ||||||
f"The {repr(argname)} option is not supported with the" | ||||||
f" {repr(engine)} engine" | ||||||
) | ||||||
else: | ||||||
value = _deprecated_defaults.get(argname, default) | ||||||
|
@@ -1080,7 +1080,7 @@ def _clean_options(self, options, engine): | |||||
if not isinstance(converters, dict): | ||||||
raise TypeError( | ||||||
f"Type converters must be a dict or subclass, " | ||||||
f"input was a {repr(type(converters).__name__)}" | ||||||
f"input was a {type(converters).__name__}" | ||||||
) | ||||||
else: | ||||||
converters = {} | ||||||
|
@@ -3607,8 +3607,8 @@ def __init__(self, f, colspecs, delimiter, comment, skiprows=None, infer_nrows=1 | |||||
|
||||||
if not isinstance(self.colspecs, (tuple, list)): | ||||||
raise TypeError( | ||||||
"column specifications must be a list or tuple, " | ||||||
"input was a %r" % type(colspecs).__name__ | ||||||
f"column specifications must be a list or tuple, " | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noted. I'll change it tonight! |
||||||
f"input was a {type(colspecs).__name__}" | ||||||
) | ||||||
|
||||||
for colspec in self.colspecs: | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I missed this in last review if you want to accept commit on GitHub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah actually I see you haven't touched this, but OK to clean up here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill fix that for you, no problem!