Skip to content

CLN: simplify pytables create_axes #30068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 5, 2019

Conversation

jbrockmendel
Copy link
Member

As mentioned in #30019, with Panel cases gone we can now deduce that len(axes) == 1 in all cases in create_axes. From there we can simplify this method a lot. This PR does most of that; some of it is held back to avoid creating merge conflicts with #30067 (orthogonal)

@jbrockmendel jbrockmendel changed the title Cln pytables indexes CLN: simplify pytables create_axes Dec 4, 2019
@jbrockmendel jbrockmendel added the IO HDF5 read_hdf, HDFStore label Dec 5, 2019
@jreback jreback added this to the 1.0 milestone Dec 5, 2019
@jreback jreback merged commit 002da29 into pandas-dev:master Dec 5, 2019
@jreback
Copy link
Contributor

jreback commented Dec 5, 2019

sure

@jbrockmendel jbrockmendel deleted the cln-pytables-indexes branch December 5, 2019 16:04
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HDF5 read_hdf, HDFStore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants