Skip to content

STY: fstrings doc/make.py #30060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 5, 2019
Merged

STY: fstrings doc/make.py #30060

merged 5 commits into from
Dec 5, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Dec 4, 2019 •
edited
Loading

@ShaharNaveh ShaharNaveh force-pushed the STY-fstrings-doc-make branch from 56d4ca6 to efd1ee6 Compare December 4, 2019 20:02
@jbrockmendel jbrockmendel added the Code Style Code style, linting, code_checks label Dec 4, 2019
WillAyd
WillAyd requested changes Dec 4, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good minor comments

@ShaharNaveh ShaharNaveh changed the title STY: fstrings STY: fstrings doc/make.py Dec 5, 2019
@ShaharNaveh ShaharNaveh requested a review from WillAyd December 5, 2019 12:35
@jreback jreback added this to the 1.0 milestone Dec 5, 2019
@jreback jreback merged commit 4abc23e into pandas-dev:master Dec 5, 2019
@jreback
Copy link
Contributor

jreback commented Dec 5, 2019

thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the STY-fstrings-doc-make branch December 5, 2019 20:32
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: fstrings doc/make.py (pandas-dev#30060)
e65d229
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: fstrings doc/make.py (pandas-dev#30060)
0c29f0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ShaharNaveh @jreback @WillAyd @jbrockmendel