Skip to content

CI: fix mypy error #30052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CI: fix mypy error #30052

wants to merge 1 commit into from

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Dec 4, 2019 •
edited
Loading

pandas/core/generic.py:9138: error: Item "None" of "Optional[DateOffset]" has no attribute "rule_code"

https://github.com/pandas-dev/pandas/runs/333145832

@simonjayhawkins simonjayhawkins added CI Continuous Integration Typing type annotations, mypy/pyright type checking labels Dec 4, 2019
@jreback
Copy link
Contributor

jreback commented Dec 4, 2019

thanks @TomAugspurger fixed it in this one: #30049

@jreback jreback closed this Dec 4, 2019
@jreback jreback reopened this Dec 4, 2019
@jreback
Copy link
Contributor

jreback commented Dec 4, 2019

actually i see you are fixing in a better way, lmk what you want to do here

@simonjayhawkins
Copy link
Member Author

actually i see you are fixing in a better way, lmk what you want to do here

Tom's fix is good for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @jreback