Skip to content

CI: ensure proper coverage of different pyarrow versions #30039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 4, 2019

Conversation

jorisvandenbossche
Copy link
Member

Closes #29223, closes #26716

@jorisvandenbossche jorisvandenbossche added CI Continuous Integration Dependencies Required and optional dependencies labels Dec 4, 2019
@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Dec 4, 2019
@jorisvandenbossche
Copy link
Member Author

Currently, pyarrow is included in the following builds:

  • azure-macos-36 as pyarrow>=0.12.0 -> this currently leads to version 0.13.0 in practice
  • azure-windows-36 as pyarrow>=0.12.0 -> this currently leads to version 0.13.0 in practice
  • travis-37 as pyarrow -> this currently leads to 0.13.0 in practice.

The reason for this is that pyarrow is only at 0.13 on the default Anaconda channel. So for a more recent version, we will need one of our builds to use conda-forge.

We should also test the oldest supported version (0.12.0), this I added to azure-36-minimum_versions

@jorisvandenbossche
Copy link
Member Author

OK, the build using conda-forge to have pyarrow 0.15 seems to work.
I could also make this a new build instead of adapting an existing one (but to me that doesn't seem worth it)

The build with the minimum of 0.12 seems to be using arrow-cpp / pyarrow from conda-forge, because 0.12 is not available on the default channel (I think only 0.9 and 0.13). I am not sure this mixing of channels will work out, but it seems to go fine (although I can't check the tests actually run and are not skipped due to an import error, since the printing of skipped tests is not working anymore -> #30040)

@jorisvandenbossche
Copy link
Member Author

@jreback jreback merged commit fe77e34 into pandas-dev:master Dec 4, 2019
@jreback
Copy link
Contributor

jreback commented Dec 4, 2019

thanks @jorisvandenbossche

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: include pyarrow 0.15.0 / latest release in one of the builds CI: Restore pyarrow for travis-3.6
3 participants