Skip to content

changed "fun !r" -> "repr(fun)" #30032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2019
Merged

changed "fun !r" -> "repr(fun)" #30032

merged 1 commit into from
Dec 4, 2019

Conversation

souravs17031999
Copy link
Contributor

@souravs17031999 souravs17031999 commented Dec 4, 2019 •
edited
Loading

As described in the following issue
, usage of !r is currently redundant and so changing to f strings in place of it.

@souravs17031999
changed "fun !r" -> "repr(fun)"
54a8ff8 
As described in the following issue
pandas-dev#29886
, usage of !r is currently redundant and so changing to f strings in place of it.
WillAyd
WillAyd requested changes Dec 4, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good to me. Can you merge master? I think should fix CI

@souravs17031999
Copy link
Contributor Author

Hi, @WillAyd , are you saying to create another PR from my master branch (i am sorry, if not able to understand what you meant) or is there any other way to merge into master ?

@simonjayhawkins
Copy link
Member

Hi, @WillAyd , are you saying to create another PR from my master branch (i am sorry, if not able to understand what you meant) or is there any other way to merge into master ?

no need to create another PR. see https://dev.pandas.io/docs/development/contributing.html#updating-your-pull-request

@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Dec 4, 2019
@jreback jreback added this to the 1.0 milestone Dec 4, 2019
@jreback jreback merged commit 739a248 into pandas-dev:master Dec 4, 2019
@jreback
Copy link
Contributor

jreback commented Dec 4, 2019

thanks @souravs17031999 CI failure is unrelated

@souravs17031999 souravs17031999 deleted the sk_change branch December 4, 2019 14:04
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@souravs17031999 @proost
changed "fun !r" -> "repr(fun)" (pandas-dev#30032)
9d3da3f
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@souravs17031999 @proost
changed "fun !r" -> "repr(fun)" (pandas-dev#30032)
f2687e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd requested changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@souravs17031999 @simonjayhawkins @jreback @WillAyd