CLN: pytables _set_tz/_get_tz #30018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Dec 4, 2019
pandas/io/pytables.py
Outdated
| values: Union[np.ndarray, Index], | ||
| tz: Optional[Union[str, tzinfo]], | ||
| coerce: bool = False, | ||
| ): |
There was a problem hiding this comment.
Is the return easy to annotate here? DTI or Ndarray?
pandas/io/pytables.py
Outdated
| coerce : if we do not have a passed timezone, coerce to M8[ns] ndarray | ||
| """ | ||
| if isinstance(values, DatetimeIndex): | ||
| # If we values is tzaware, the tz gets dropped in the values.ravel() |
jreback
requested changes
Dec 4, 2019
| # call below (which returns an ndarray). So we are only non-lossy | ||
| # if `tz` matches `values.tz`. | ||
| assert values.tz is None or values.tz == tz | ||
|
|
||
| if tz is not None: | ||
| name = getattr(values, "name", None) | ||
| values = values.ravel() |
There was a problem hiding this comment.
i wonder if we need the ravel any longer
There was a problem hiding this comment.
i havent checked if we ever actually pass 2D ndarray, but the ravel is definitely needed in the case where we have a DTI (or we would have to replace it with DTI-specific code) (see the comment a few lines up)
jreback
approved these changes
Dec 4, 2019
|
ok sure |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes preserve_UTC argument, which never did anything, and didnt have a clear purpose