Skip to content

DOC: Added "Raises KeyError" #30014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2019
Merged

DOC: Added "Raises KeyError" #30014

merged 3 commits into from
Dec 4, 2019

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

WillAyd
WillAyd requested changes Dec 4, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about these changes - is this purely a stylistic thing you are aiming for?

@ShaharNaveh
Copy link
Member Author

Not sure about these changes - is this purely a stylistic thing you are aiming for?

Yes, indeed purely stylistic change, I'll revert.

@jreback jreback added this to the 1.0 milestone Dec 4, 2019
@jreback jreback merged commit c20106f into pandas-dev:master Dec 4, 2019
@jreback
Copy link
Contributor

jreback commented Dec 4, 2019

thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the DOC-compact-chainmap branch December 4, 2019 15:18
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
DOC: Added "Raises KeyError" (pandas-dev#30014)
55a5684
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
DOC: Added "Raises KeyError" (pandas-dev#30014)
27b6bb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@WillAyd WillAyd WillAyd requested changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ShaharNaveh @jreback @WillAyd @jbrockmendel @alimcmaster1