TYP: some types for pandas/io/formats/csvs.py #30000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Dec 3, 2019
pandas/io/formats/csvs.py
Outdated
| @@ -187,7 +188,7 @@ def save(self): | |||
| close = True | |||
|
|
|||
| try: | |||
| writer_kwargs = dict( | |||
| kwargs: Dict[str, Any] = dict( | |||
There was a problem hiding this comment.
why the rename? ive recently been finding more-specific names for kwargs useful when tracking down less-specific usages
There was a problem hiding this comment.
no reason other than for consistency of variable names. will revert tomorrow.
|
LGTM; CI failures are unrelated |
|
rebased + green |
|
thanks @simonjayhawkins |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broken off #28339