Skip to content

CLN: explicit kwargs and docstring for create_index #29971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2019
Merged

CLN: explicit kwargs and docstring for create_index #29971

merged 1 commit into from
Dec 2, 2019

Conversation

jbrockmendel
Copy link
Member

Side-note, in create_index, none of our tests hit the v.remove_index() calls. If we could rule those out, this function could be simplified quite a bit.

WillAyd
WillAyd approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.0 milestone Dec 2, 2019
@WillAyd WillAyd added the IO HDF5 read_hdf, HDFStore label Dec 2, 2019
@jreback jreback merged commit 095b13f into pandas-dev:master Dec 2, 2019
@jreback
Copy link
Contributor

jreback commented Dec 2, 2019

thanks.

.remove_index() was added for to have the mirror routine, but yes likely not used.

@jbrockmendel jbrockmendel deleted the cln-pytables-kwargs-create_index2 branch December 2, 2019 23:19
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
CLN: explicit kwargs and docstring for create_index (pandas-dev#29971)
8e9d9eb
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
CLN: explicit kwargs and docstring for create_index (pandas-dev#29971)
f34157e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
IO HDF5 read_hdf, HDFStore
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @WillAyd