CLN: f-string in pandas/core/window/* #29952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
ganevgv
force-pushed
the
clean/f_string_core_window
branch
from
b023181 to
80f9c1b
Compare
|
finally ready for review |
WillAyd
requested changes
Dec 2, 2019
pandas/core/window/expanding.py
Outdated
| @@ -209,10 +209,10 @@ def skew(self, **kwargs): | |||
|
|
|||
| >>> arr = [1, 2, 3, 4, 999] | |||
| >>> import scipy.stats | |||
| >>> fmt = "{0:.6f}" # limit the printed precision to 6 digits | |||
| >>> print(fmt.format(scipy.stats.kurtosis(arr[:-1], bias=False))) | |||
| >>> precision = 6 # limit the printed precision to 6 digits | |||
There was a problem hiding this comment.
Minor but I find this rather distracting from the code sample. Can you just hard-code the format specifier in the print statements below?
There was a problem hiding this comment.
Sounds good - just did that.
|
thanks @ganevgv |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #29547
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff