CLN: OrderedDict -> Dict #29923
Merged
CLN: OrderedDict -> Dict #29923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you use dict literals where possible, i.e. Else LGTM. |
|
@alimcmaster1 yeah lgtm. but agree we need a code check here, can you add. |
|
Thanks @topper-123 updated as per your comments. @jreback sure will add a code check in a follow up - there are still some more references to remove but ill save those for next PR |
topper-123
reviewed
Dec 1, 2019
| @@ -2992,7 +2991,7 @@ def _write_map(self): | |||
| the map with 0s. The second call writes the final map locations when | |||
| all blocks have been written.""" | |||
| if self._map is None: | |||
| self._map = OrderedDict( | |||
| self._map = dict( | |||
| ( | |||
There was a problem hiding this comment.
A last one missing here, else looks good.
|
Thanks @alimcmaster1 |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasAs of CPython 3.6 the implementation of dict maintains insertion order.
This became a language feature in python 3.7.
Note in python 3.8 support for reversed(dict) was added - but we don't seem to use that in the use cases i've eliminated.
There is more to do here.