TYP: some types for pandas/core/arrays/sparse/dtype.py #29899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/arrays/sparse/dtype.py
Outdated
| @@ -223,7 +223,7 @@ def construct_from_string(cls, string): | |||
| raise TypeError(msg) | |||
|
|
|||
| @staticmethod | |||
| def _parse_subtype(dtype): | |||
| def _parse_subtype(dtype) -> Tuple[str, Union[str, bool]]: | |||
There was a problem hiding this comment.
not necessarily for this PR, but the Union[str, bool] is kind of weird. maybe split into separate return values with clearer types?
There was a problem hiding this comment.
can dtype be typed as str?
There was a problem hiding this comment.
maybe we could cast has_fill_value to bool before returning. cast as in the dynamic bool(...) sense not cast from typing?
|
Pending typing |
WillAyd
approved these changes
Nov 29, 2019
|
Thanks ! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broken off #28339