Skip to content

BUG: .count() raises if use_inf_as_na is enabled #29888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2019

Conversation

thy09
Copy link
Contributor

@thy09 thy09 commented Nov 27, 2019

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR thanks for the submission. Can you add a whatsnew note for 1.0.0 as well?

@WillAyd WillAyd added Regression Functionality that used to work in a prior pandas version Datetime Datetime data dtype labels Nov 27, 2019
@WillAyd WillAyd added this to the 1.0 milestone Nov 27, 2019
@jreback jreback changed the title Fix bug: GH29478 BUG: .count() raises if use_inf_as_na is enabled Nov 27, 2019
@thy09 thy09 force-pushed the thy09/fix-bug-datetimearray-isna_old branch from 8b1e34d to 151c1a1 Compare November 28, 2019 01:18
@thy09 thy09 force-pushed the thy09/fix-bug-datetimearray-isna_old branch from 2866e17 to 7db70f8 Compare November 28, 2019 05:23
@WillAyd WillAyd merged commit f98d2b6 into pandas-dev:master Nov 29, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 29, 2019

Thanks @thy09

@thy09
Copy link
Contributor Author

thy09 commented Nov 30, 2019

It's my pleasure!

When will the next version release?
This issue caused some problems in our project now.

@jorisvandenbossche
Copy link
Member

When will the next version release?

Pandas 1.0 is planned for beginning next year

@thy09
Copy link
Contributor Author

thy09 commented Dec 19, 2019

Thanks a lot!

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Regression Functionality that used to work in a prior pandas version
Projects
None yet
3 participants