Skip to content

CLN:Added annotations to functions #29821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2019
Merged

CLN:Added annotations to functions #29821

merged 1 commit into from
Nov 25, 2019

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jbrockmendel
Copy link
Member

im not sure if we have a convention for __setstate__ or strptime cases, the rest look good

@ShaharNaveh
Copy link
Member Author

im not sure if we have a convention for __setstate__ or strptime cases, the rest look good

Would you like me to remove them, at least for this PR. and open a separate one containing only them?

@gfyoung gfyoung added Typing type annotations, mypy/pyright type checking Internals Related to non-user accessible pandas implementation labels Nov 24, 2019
@jbrockmendel
Copy link
Member

Would you like me to remove them, at least for this PR. and open a separate one containing only them?

Either that or wait for @WillAyd to chime in

@jbrockmendel
Copy link
Member

Thanks @MomIsBestFriend

@jbrockmendel jbrockmendel merged commit b366ce8 into pandas-dev:master Nov 25, 2019
@ShaharNaveh ShaharNaveh deleted the CLN-typ branch November 25, 2019 22:36
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
Added annotations to functions (pandas-dev#29821)
bf44bc5
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
Added annotations to functions (pandas-dev#29821)
42f8982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShaharNaveh @jbrockmendel @gfyoung