Skip to content

BUG: add reset logic for Grouper if new obj is passed in (#26564) #29800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

BUG: add reset logic for Grouper if new obj is passed in (#26564) #29800

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d03142e
BUG: add reset logic for Grouper if new obj is passed in (#26564)
alichaudry Nov 22, 2019
05f649e
BUG: adding test and addressing a comment on shortened URL (#26564)
alichaudry Nov 22, 2019
0043739
BUG: make test df simpler and change to agg funcs (#29800)
alichaudry Nov 25, 2019
173f24a
Merge remote-tracking branch 'upstream/master' into pd-grouper-no-in-…
alichaudry Jan 2, 2020
8f473d2
Merge branch 'master' into pd-grouper-no-in-place
alichaudry Feb 6, 2020
8dea17d
BUG: conform to standard test format (#29800)
alichaudry Feb 6, 2020
5a1889b
BUG: blacken test (#29800)
alichaudry Feb 6, 2020
12e3b4f
BUG: remove groupby fix and xfail test (#29800)
alichaudry Feb 7, 2020
079c847
BUG: fix import sort order (#29800)
alichaudry Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pandas/core/groupby/grouper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,13 @@ def __init__(self, key=None, level=None, freq=None, axis=0, sort=False):
self.axis = axis
self.sort = sort

self._reset_grouper()

def _reset_grouper(self):
"""
Ensures Grouper object can be reused
See https://bit.ly/2D4Yd6V
"""
self.grouper = None
self.obj = None
self.indexer = None
Expand Down Expand Up @@ -155,6 +162,8 @@ def _set_grouper(self, obj: FrameOrSeries, sort: bool = False):
whether the resulting grouper should be sorted
"""
assert obj is not None
if not obj.equals(self.obj):
self._reset_grouper()

if self.key is not None and self.level is not None:
raise ValueError("The Grouper cannot specify both a key and a level!")
Expand Down