Skip to content

CLN - Change string formatting in plotting #29781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2019

Conversation

ohad83
Copy link
Contributor

@ohad83 ohad83 commented Nov 21, 2019

Changed the string formatting in pandas/plotting/*.py to f-strings.

  • tests passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

ref #29547

Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments.

@topper-123 topper-123 added this to the 1.0 milestone Nov 21, 2019
Removed unnecessary intermediates and added needed intermediate for
clarification.
@topper-123 topper-123 merged commit c557629 into pandas-dev:master Nov 21, 2019
@topper-123
Copy link
Contributor

Thanks, @ohad83!

@ohad83 ohad83 deleted the CLN-fstring-plotting branch November 21, 2019 23:31
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants