REF: avoid returning self in io.pytables #29776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jreback it looks like the LegacyFixed methods are not covered in the tests. Any chance we can rip out those classes? |
|
also read_sparse_intindex, write_sparse_intindex, read_block_index, write_block_index, so we might not need BlockIndex/IntIndex (which are imported from arrays.sparse)? |
|
so i think i can blow away all Legacy stuff i think these read the legacy_hdf dir in data/ but these are quite old iirc also exception on line 635 can remove that is some versions prior to what we support now |
|
great, i'll make a PR specific to ripping that stuff out. hopefully that will snowball into more simplfications |
|
thanks |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small step towards making these less stateful