TST: add test for rolling max with DatetimeIndex #29761
Conversation
ganevgv
force-pushed
the
tests/test_rolling_max_datetimeindex
branch
from
96f5103 to
8f66410
Compare
ganevgv
force-pushed
the
tests/test_rolling_max_datetimeindex
branch
from
8f66410 to
7852918
Compare
pandas/tests/window/test_moments.py
Outdated
| @@ -1891,6 +1891,20 @@ def test_rolling_corr_with_zero_variance(self, window): | |||
|
|
|||
| assert s.rolling(window=window).corr(other=other).isna().all() | |||
|
|
|||
| def test_rolling_max_datetimeindex(self): | |||
There was a problem hiding this comment.
move to tests/window/test_timeseries_window.py and put near similar tests (this might be a duplicate)
There was a problem hiding this comment.
Thanks for the feedback, @jreback. Moved the test to tests/window/test_timeseries_window.py. This test is different by being the only one using minutes as frequency in the file. Other minor differences is that it's using Series as opposed to DataFrame and explicit definition of expected.
Having said that, I agree that there are very similar tests and I'm happy to remove it all together.
There was a problem hiding this comment.
@ganevgv if you would like to clean that up and parametrize frequencies / containers that would be very welcome
jreback
added
Window
|
thanks @ganevgv I would love if you could parametrize some of these tests (e.g. also test min) in a followup if you can. |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff