ANN: types for _create_storer #29757
Conversation
jbrockmendel
commented
Nov 20, 2019
jbrockmendel
commented
- Annotate return type for _create_storer
- Annotate other functions that we can reason about given 1
- Fixups to address mypy warnings caused by 1 and 2
| except KeyError: | ||
| error("_TYPE_MAP") | ||
| raise error("_TYPE_MAP") |
There was a problem hiding this comment.
will this make sense now that _TYPE_MAP is inlined?
There was a problem hiding this comment.
I guess we could inline the thing here too
|
@jbrockmendel looking good. |
In this case I think they're better kept as the Union. In a perfect world id like to get separate functions one of which returns Table and the other returns GenericFixed, but i couldn't come up with a nice way of pre-checking |
|
i think i merged in an odd order, pls rebase |
|
merged lots of stuff, can you rebase just to be sure here. |
|
rebased+green |
| where=where, start=start, stop=stop, **kwargs | ||
| ) | ||
| tbl = self.get_storer(key) | ||
| if not isinstance(tbl, Table): |
There was a problem hiding this comment.
mypy mostly. get_storer can return two different types, and this method only works if we get a Table back
|
k thanks |
