TYP: Add type hint for BaseGrouper in groupby._Groupby #29675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
add_type_for_GroupBy.grouper
branch
from
2d433c4 to
4d0cd8d
Compare
topper-123
force-pushed
the
add_type_for_GroupBy.grouper
branch
from
4d0cd8d to
30bdcab
Compare
| @@ -442,7 +442,7 @@ def get_grouper( | |||
| observed: bool = False, | |||
| mutated: bool = False, | |||
| validate: bool = True, | |||
| ) -> Tuple[BaseGrouper, List[Hashable], FrameOrSeries]: | |||
| ) -> "Tuple[ops.BaseGrouper, List[Hashable], FrameOrSeries]": | |||
There was a problem hiding this comment.
any reason to add quotes? don't we lose the black formatting checking by doing this?
There was a problem hiding this comment.
Without the quotes we get a circular import error, so needs to be quoted.
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a type hint in class
_GroupbyforBaseGrouperto aid navigating the code base.