Extension Module Compat Cleanup #29666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Clean
Internals
gfyoung
reviewed
Nov 17, 2019
pandas/_libs/src/parser/io.c
Outdated
| @@ -17,7 +17,7 @@ The full license is in the LICENSE file, distributed with this software. | |||
| #define O_BINARY 0 | |||
| #endif // O_BINARY | |||
|
|
|||
| #if PY_VERSION_HEX >= 0x03060000 && defined(_WIN32) | |||
| #ifdef(_WIN32) | |||
There was a problem hiding this comment.
I saw some compilation failures around this.
Can't we just do a pure clean and remove the PY_VERSiON_HEX check from that if statement?
| @@ -38,13 +38,9 @@ PANDAS_INLINE int slice_get_indices(PyObject *s, | |||
| Py_ssize_t *stop, | |||
| Py_ssize_t *step, | |||
| Py_ssize_t *slicelength) { | |||
| #if PY_VERSION_HEX >= 0x03000000 | |||
|
|
|||
| return PySlice_GetIndicesEx(s, length, start, stop, | |||
| step, slicelength); | |||
There was a problem hiding this comment.
if we're returning this unchanged, can we just use this function directly and not define an alias? i guess the pypy thing above might complicate this?
There was a problem hiding this comment.
Unclear for me at this point, but makes sense to investigate in a follow-up.
|
lgtm, pending green. |
|
thanks |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff