Skip to content

CI: Fix error when creating postgresql db #29655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 16, 2019
Merged

CI: Fix error when creating postgresql db #29655

merged 6 commits into from
Nov 16, 2019

Conversation

datapythonista
Copy link
Member

Not sure if this makes sense, but let's try if this is the problem.

@datapythonista datapythonista added the CI Continuous Integration label Nov 16, 2019
@datapythonista
Copy link
Member Author

Looks like this change adds this at the beginning of the log:

$ travis_setup_postgresql
Starting PostgreSQL v9.2
sudo service postgresql start 9.2
$ sudo service mysql start
start: Job is already running: mysql

But still the same error. I guess we'll have to add traces during the build to see if the postgres service is running, and what are the server, port...

@jbrockmendel
Copy link
Member

maybe if we used 9.5 instead of 9.2? the log has a bit about shutting down 9.5, then starting 9.4 then stopping 9.4, then starting 9.3...

@datapythonista
Copy link
Member Author

Didn't see that, let's see if this works. I'm going to sleep now, feel free to push here if you want to try more things.

@alimcmaster1
Copy link
Member

Maybe someone from @travis-ci can help us here?

@datapythonista
Copy link
Member Author

I'm going to move the failing build to GitHub actions. That was more or less planned (#28545), and looks like shouldn't be difficult.

@jreback
Copy link
Contributor

jreback commented Nov 16, 2019

let’s just disable the server for now
until it can be diagnosed

@datapythonista
Copy link
Member Author

datapythonista commented Nov 16, 2019

let’s just disable the server for now

Not sure what do you mean. Disable the failing build?

I guess if we temporary disable the creation of the db, and remove psycopg2 from the dependencies, the CI will be green again, and just the postgres tests will be skipped.

But with some luck I can move the build to GitHub actions easily, and we can keep running the postgres tests, and have a permanent solution. I'll need #29661 merged soon for that.

@datapythonista
Copy link
Member Author

I think the problem is that something in https://github.com/pandas-dev/pandas/blob/master/ci/deps/travis-36-cov.yaml is making conda install postgres, see:

postgresql                11.2                 h20c2e04_0

I didn't see that there are two travis builds where the db is correctly created, and I think this is the main difference. In the working builds postgres is not installed.

Let's see if uninstalling coda fixes the error.

@datapythonista datapythonista changed the title CI: Adding dbs explicitly to travis CI: Fix error when creating postgresql db Nov 16, 2019
@datapythonista
Copy link
Member Author

@pandas-dev/pandas-core this fixes the problem with the CI (the postgresql error)

@jreback jreback added this to the 1.0 milestone Nov 16, 2019
@jreback
Copy link
Contributor

jreback commented Nov 16, 2019

great merge one green

@datapythonista datapythonista merged commit cd013b4 into pandas-dev:master Nov 16, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: postgresql job failing
4 participants