Skip to content

CI: bump mypy 0.730 #29653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2019
Merged

CI: bump mypy 0.730 #29653

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
add3300
CI: bump mypy 0.730
simonjayhawkins Nov 16, 2019
36dc769
Merge remote-tracking branch 'upstream/master' into bump-mypy-0.730
simonjayhawkins Nov 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies:
- flake8-comprehensions>=3.1.0 # used by flake8, linting of unnecessary comprehensions
- flake8-rst>=0.6.0,<=0.7.0 # linting of code blocks in rst files
- isort # check that imports are in the right order
- mypy=0.720
- mypy=0.730
- pycodestyle # used by flake8

# documentation
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ flake8
flake8-comprehensions>=3.1.0
flake8-rst>=0.6.0,<=0.7.0
isort
mypy==0.720
mypy==0.730
pycodestyle
gitpython
sphinx
Expand Down
5 changes: 4 additions & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,13 @@ ignore_errors=True
[mypy-pandas.tests.extension.json.test_json]
ignore_errors=True

[mypy-pandas.tests.indexes.datetimes.test_tools]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref #28932, add #type: ignore as an alternative to ignoring all errors in module

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a 'cleaner' fix in 9849163, that could be simply reverted when --warn-unused-ignores reports issue fixed.

ignore_errors=True

[mypy-pandas.tests.indexes.test_base]
ignore_errors=True

[mypy-pandas.tests.indexing.test_loc]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a false positive in 0.720 so can be removed

[mypy-pandas.tests.scalar.period.test_period]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now giving error: Module has no attribute "__version__" following #29212

again could add #type: ignore, see cfc2ef7

ignore_errors=True

[mypy-pandas.tests.series.test_operators]
Expand Down