CI: fix flake C413, C414, C416 errors #29646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
CI
datapythonista
approved these changes
Nov 15, 2019
jschendel
reviewed
Nov 15, 2019
There was a problem hiding this comment.
looks good overall; can you also pin the flake8-comprehensions version in the pre-commit configuration, so it automatically updates for people who've already installed pre-commit:
pandas/.pre-commit-config.yaml
Line 12 in 4313267
Just need to modify it to be flake8-comprehensions==3.1.0 (maybe >= would also be okay?)
|
Thanks @jschendel comments addressed |
jschendel
approved these changes
Nov 16, 2019
jreback
reviewed
Nov 16, 2019
| @@ -9,7 +9,7 @@ repos: | |||
| hooks: | |||
| - id: flake8 | |||
| language: python_venv | |||
| additional_dependencies: [flake8-comprehensions] | |||
| additional_dependencies: [flake8-comprehensions>=3.1.0] | |||
There was a problem hiding this comment.
you should also change in environment.yaml
There was a problem hiding this comment.
Thanks @jreback done.
|
we should merge this, i.e. not wait for the postgres thing to get sorted out |
|
sure lgtm go for it |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff