Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding (Insert or update if key exists) option to .to_sql #14553 #29636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding (Insert or update if key exists) option to .to_sql #14553 #29636
Changes from 42 commits
848becc
d9f7c23
f0726b3
c742f47
d2a0c2d
686930c
1f47d45
881a934
c95de1d
0082347
2d85c70
0f32cd0
dc70c40
a7b8e8e
1d936ef
9db2aaa
57a246d
c290a78
35e0fc4
6bcd6c2
00e6319
8d654ca
966a95c
b214a68
41938cd
78f8e86
025b0ef
bbcf92b
73fea73
d8b7686
75e16ff
0dfe913
779818a
3fafc95
d79b970
c38f900
0636332
a15fc2f
6c44506
e409bda
d35e145
8a57126
3c308d3
d4764dc
4396aa3
2b1c797
b23f528
899da90
8ebc256
baad9e3
79ef9c0
d0eb251
b838ef5
17a1d42
a25c2f3
f56b53f
247bec0
51a74a2
91c750b
f940b42
6dedb71
e3809a1
6d692cd
efd2382
c3a6a95
a0ce842
07bc8ca
4822ce0
0fba1b6
c230d16
9a7ef9c
2a078f6
c3c6ed1
79becdc
3b6ca76
61d998f
e454c35
b4c058c
2ed4d32
c33d536
b3bfbcc
fafd646
dbee26b
3a04edd
0b03df7
f2d3596
529e5fb
6d718dc
53e3565
1bff71f
26c0b0f
59c76ac
21a87e1
286e8b8
780fcea
70e0eb1
d4fc6d4
c783496
4f4e9d9
e466ff3
f2bc121
b9bfedc
43353f5
6196c29
b27449e
c8c1826
e28cd9e
197e172
6ebe9e8
b95f6c9
8fa8e0e
1dee409
1f9fca7
2b30a9e
a05937e
67143ff
7e1148e
11f201f
7f0b5dd
e5d5ce7
8123cd7
26faabe
9260eca
ad9f52f
a63a77a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be more clearly expressed as
self.table.c[primary_keys].itertuples(index=False)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @WillAyd - thanks for the feedback.
self.table
is a sqlalchemyTable
object, anditertuples
is aDataFrame
method, so as I understand it, this wouldn't work. If I'm missing the point, please let me know and I'll adjust this and theselect
statement accordingly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment - can you just select without looping?