REF: de-duplicate _apply_to_group #29628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 16, 2019
| @@ -189,6 +189,24 @@ cdef class _BaseGrouper: | |||
|
|
|||
| return cached_typ, cached_ityp | |||
|
|
|||
| cdef inline object _apply_to_group(self, | |||
There was a problem hiding this comment.
i would return a tuple(res, intitialized) here, less c-like i think is good generally (and this likely doesn't make it differetnt perf wise as this is object anyhow)
| object cached_typ, object cached_ityp, | ||
| Slider islider, Slider vslider, | ||
| Py_ssize_t group_size, bint* initialized): | ||
| cached_ityp._engine.clear_mapping() |
There was a problem hiding this comment.
can you add some sort of doc-string
jreback
approved these changes
Nov 17, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functionally identical code in SeriesGrouper.get_result and SeriesBinGrouper.get_result, now shared.