CLN: reshape #29627
Merged
CLN: reshape #29627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 16, 2019
| return cons(mgr, name=name).__finalize__(self, method="concat") | ||
|
|
||
| # combine as columns in a frame | ||
| else: | ||
| data = dict(zip(range(len(self.objs)), self.objs)) | ||
| cons = _get_series_result_type(data) | ||
| cons = DataFrame |
There was a problem hiding this comment.
does this play nice with subclassing?
There was a problem hiding this comment.
probably not, but its the exact behavior we currently have
| @@ -129,6 +131,8 @@ def lreshape(data, groups, dropna=True, label=None): | |||
| groups : dict | |||
| {new_name : list_of_columns} | |||
| dropna : boolean, default True | |||
| label : object, default None | |||
There was a problem hiding this comment.
should deprecate / remove this
There was a problem hiding this comment.
can you create an issue to deprecate this
| # get left & right join labels and num. of levels at each location | ||
| llab, rlab, shape = map(list, zip(*map(fkeys, left_keys, right_keys))) | ||
| mapped = ( |
There was a problem hiding this comment.
can use enumerate here instead of range(len(...))
pandas/core/reshape/merge.py
Outdated
| mapped = (fkeys(index.levels[n], join_keys[n]) for n in range(len(index.levels))) | ||
| mapped = ( | ||
| _factorize_keys(index.levels[n], join_keys[n], sort=sort) | ||
| for n in range(len(index.levels)) |
jreback
added
Clean
Typing
WillAyd
reviewed
Nov 17, 2019
pandas/core/reshape/concat.py
Outdated
| @@ -541,7 +537,7 @@ def _get_concat_axis(self): | |||
| idx = ibase.default_index(len(self.objs)) | |||
| return idx | |||
| elif self.keys is None: | |||
| names = [None] * len(self.objs) | |||
| names = [None] * len(self.objs) # type: list | |||
There was a problem hiding this comment.
At least for now should always prefer typing.* to the builtin containers
pandas/core/reshape/melt.py
Outdated
| @@ -412,14 +416,14 @@ def wide_to_long(df, stubnames, i, j, sep: str = "", suffix: str = r"\d+"): | |||
| two 2.9 | |||
| """ | |||
|
|
|||
| def get_var_names(df, stub, sep, suffix): | |||
| def get_var_names(df, stub: str, sep: str, suffix) -> List[str]: | |||
There was a problem hiding this comment.
I think can annotation suffix as a str
jreback
requested changes
Nov 17, 2019
pandas/core/reshape/concat.py
Outdated
| @@ -537,7 +538,7 @@ def _get_concat_axis(self): | |||
| idx = ibase.default_index(len(self.objs)) | |||
| return idx | |||
| elif self.keys is None: | |||
| names = [None] * len(self.objs) | |||
| names = [None] * len(self.objs) # type: List | |||
| @@ -129,6 +131,8 @@ def lreshape(data, groups, dropna=True, label=None): | |||
| groups : dict | |||
| {new_name : list_of_columns} | |||
| dropna : boolean, default True | |||
| label : object, default None | |||
jreback
approved these changes
Nov 20, 2019
|
thanks, if you can create an issue for that deprecation |
jacobaustin123
pushed a commit
to jacobaustin123/pandas
that referenced
this pull request
Nov 20, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think some of this can be made easier to reason about (like with making FrameApply less stateful), as a preliminary this is just some mild annotations etc