Skip to content

BUG keep name after DataFrame drop, add check_name to assert_dataframe_equal #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2013

Conversation

hayd
Copy link
Contributor

@hayd hayd commented Mar 3, 2013

This should fix #2939. (redo of pull-request #2961, which I screwed up).

@hayd
Copy link
Contributor Author

hayd commented Mar 3, 2013

I want to default check_names to True but at the moment this causes some errors (some are just test expected not including name...), some may be bugs. Work in progress... I'll put it in another branch.

Update: It looks like there'll be a couple of similar (name-based) bugs...

hayd added a commit that referenced this pull request Mar 7, 2013
BUG keep name after DataFrame drop, add check_name to assert_dataframe_equal
@hayd hayd merged commit 501ba37 into pandas-dev:master Mar 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.drop loses index name
1 participant