Skip to content

REF: eliminate eval_kwargs #29611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 14, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 14, 2019

This is a preliminary for the arithmetic refactor. (Not strictly necessary, but preferable, and it is a reasonable scope to split off)

@gfyoung gfyoung added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels Nov 14, 2019
@jreback jreback added this to the 1.0 milestone Nov 14, 2019
@jreback
Copy link
Contributor

jreback commented Nov 14, 2019

lgtm. ping on green.

@jbrockmendel
Copy link
Member Author

ping

@jorisvandenbossche jorisvandenbossche merged commit 71b7868 into pandas-dev:master Nov 14, 2019
@jbrockmendel jbrockmendel deleted the eval_kwargs branch November 14, 2019 20:17
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants