Skip to content

REF: de-nest _get_cython_function #29609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 14, 2019
Merged

REF: de-nest _get_cython_function #29609

merged 6 commits into from
Nov 14, 2019

Conversation

jbrockmendel
Copy link
Member

No description provided.

@gfyoung gfyoung added Clean Internals Related to non-user accessible pandas implementation labels Nov 14, 2019
@jreback jreback added this to the 1.0 milestone Nov 14, 2019
jreback
jreback approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Performing static analysis using mypy
pandas/core/groupby/generic.py:1071: error: Need type annotation for 'result'
Performing static analysis using mypy DONE**

@jreback jreback merged commit 4ef7313 into pandas-dev:master Nov 14, 2019
@jreback
Copy link
Contributor

jreback commented Nov 14, 2019

thanks

@jbrockmendel jbrockmendel deleted the faster58 branch November 14, 2019 16:38
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@jbrockmendel
REF: de-nest _get_cython_function (pandas-dev#29609)
60b6df6
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
REF: de-nest _get_cython_function (pandas-dev#29609)
6139989
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
REF: de-nest _get_cython_function (pandas-dev#29609)
1207f59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @gfyoung